Where is the war?

Hi,

When building the latest version using mvn install in the dhis-web folder, I don’t see the dhis.war in the familiar place dhis-web/dhis-web-portal/target ?

···


Cheers,
Knut Staring

Now you have to come back to the past familiar work, that go to dhis-web-portal folder and build with mvn again.

Thanks Thuy - that is certainly straightforward.

But could someone comment on why this is changing back and forth? Was the previous change a mistake?

Knut

···

On Tue, Oct 20, 2009 at 6:30 PM, Thuy Nguyen thuy.hispvietnam@gmail.com wrote:

On Tue, Oct 20, 2009 at 11:29 PM, Knut Staring knutst@gmail.com wrote:

Hi,

When building the latest version using mvn install in the dhis-web folder, I don’t see the dhis.war in the familiar place dhis-web/dhis-web-portal/target ?


Cheers,
Knut Staring


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Thuy
HISP Vietnam
+84902079126


Cheers,
Knut Staring

Fixed.

···

On Tue, Oct 20, 2009 at 6:40 PM, Knut Staring knutst@gmail.com wrote:

On Tue, Oct 20, 2009 at 6:30 PM, Thuy Nguyen thuy.hispvietnam@gmail.com wrote:

Now you have to come back to the past familiar work, that go to dhis-web-portal folder and build with mvn again.

Thanks Thuy - that is certainly straightforward.

But could someone comment on why this is changing back and forth? Was the previous change a mistake?

Knut

On Tue, Oct 20, 2009 at 11:29 PM, Knut Staring knutst@gmail.com wrote:

Hi,

When building the latest version using mvn install in the dhis-web folder, I don’t see the dhis.war in the familiar place dhis-web/dhis-web-portal/target ?


Cheers,
Knut Staring


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Thuy
HISP Vietnam
+84902079126


Cheers,
Knut Staring


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Sorry for the spam, but I couldn't help it when I (to my great surprise,
before I understood what you were talking about) saw the subject. To quote
Leonard Cohen:

There is a war between the rich and poor,
a war between the man and the woman.
There is a war between the ones who say there is a war
and the ones who say there isn't.

Johan

···

Fixed.

On Tue, Oct 20, 2009 at 6:40 PM, Knut Staring <knutst@gmail.com> wrote:

On Tue, Oct 20, 2009 at 6:30 PM, Thuy Nguyen >> <thuy.hispvietnam@gmail.com>wrote:

Now you have to come back to the past familiar work, that go to
dhis-web-portal folder and build with mvn again.

Thanks Thuy - that is certainly straightforward.

But could someone comment on why this is changing back and forth? Was
the
previous change a mistake?
Knut

On Tue, Oct 20, 2009 at 11:29 PM, Knut Staring <knutst@gmail.com> >>> wrote:

Hi,
When building the latest version using mvn install in the dhis-web
folder, I don't see the dhis.war in the familiar place
dhis-web/dhis-web-portal/target ?

--
Cheers,
Knut Staring

_______________________________________________
Mailing list:
https://launchpad.net/~dhis2-devs<https://launchpad.net/~dhis2-devs>
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe :
https://launchpad.net/~dhis2-devs<https://launchpad.net/~dhis2-devs>
More help : https://help.launchpad.net/ListHelp

--
--
Thuy
HISP Vietnam
+84902079126

--
Cheers,
Knut Staring

_______________________________________________
Mailing list:
https://launchpad.net/~dhis2-devs<https://launchpad.net/~dhis2-devs>
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe :
https://launchpad.net/~dhis2-devs<https://launchpad.net/~dhis2-devs>
More help : https://help.launchpad.net/ListHelp

_______________________________________________
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help : https://help.launchpad.net/ListHelp

Hi all,

Just to clarify (on the technical issue and not the politics (leave that to Johan).

Lars fixed this by editing the pom.xml file in dhis-2/dhis-web/ (line 25 here http://bazaar.launchpad.net/%7Edhis2-devs-core/dhis2/trunk/revision/895/dhis-2/dhis-web/pom.xml)

This file controls which modules that will be built by maven when you do a ‘mvn install’ command in this folder.
The dhis-web-portal module was added here some months ago, which made packaging war files a lot easier since there is no longer a need to do a ‘mvn package’ command in dhis-web-portal. As far as I know this change was never communicated.

Many of you are making changes to this important pom.xml file and I can see that in revision 872 (on Oct 16, committed by Tri) the dhis-web-portal module was commented out, which of course means the war will not be built when building dhis-web.

Please be careful when editing the root poms (dhis-2/ and dhis-web/ ) as it can have major consequences. I also think better information is needed to orient everyone of important changes like adding dhis-web-portal to the dhis-web pom file, as this changes how everyone builds the war file. And hopefully better communication also will lead to less commit problems like the one here, as we will hopefully all know why the pom is set up the way it is and which parts that should not be changed.

Ola

···

2009/10/21 Lars Helge Øverland larshelge@gmail.com

Fixed.

On Tue, Oct 20, 2009 at 6:40 PM, Knut Staring knutst@gmail.com wrote:

On Tue, Oct 20, 2009 at 6:30 PM, Thuy Nguyen thuy.hispvietnam@gmail.com wrote:

Now you have to come back to the past familiar work, that go to dhis-web-portal folder and build with mvn again.

Thanks Thuy - that is certainly straightforward.

But could someone comment on why this is changing back and forth? Was the previous change a mistake?

Knut

On Tue, Oct 20, 2009 at 11:29 PM, Knut Staring knutst@gmail.com wrote:

Hi,

When building the latest version using mvn install in the dhis-web folder, I don’t see the dhis.war in the familiar place dhis-web/dhis-web-portal/target ?


Cheers,
Knut Staring


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Thuy
HISP Vietnam
+84902079126


Cheers,
Knut Staring


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp