Trunk tracker bugs/issues

Hi devs,
this might all be known issues since this is trunk, but I’ve been testing the tracker (EC/TC) part of trunk the last two days and though I’d report the issues I’ve come over:

  • TC: «auto-generate event» and «open data entry after enrollment» does not seem to work, at least not in the instance I’ve tested with (worked in 2.23)

  • TC: the new «show error and prevent completion» program rule action is not triggered if there are also required/compulsory fields that are missing when clicking complete. I think it would make sense to show all errors that prevent the complete action when clicking complete?

  • TC: I get an exception related to a program rule when enrolling new TEIs (see screenshots). It tries to access the trackedentityattribute.id of the «effect», which is null because the programruleaction is linked only to a data element. (This is an «ASSIGN» type action).

  • Backend/maintenance: the programruleaction table leaves «orphaned» actions, e.g. action not associated with a rule - I assume these should have been deleted?

  • EC: would be nice if report date could be embedded in custom forms - support for this seems to have been going in and out over the last few versions

  • TC/EC: Form/font sizes seems to be different for custom forms in the two apps. EC size (12pt) seems more «normal» to me (vs 14pt in TC)

    • a few program rule issues already sent to Markus…

Regards

Olav

Thanks Olav,
see some inline comments.

Hi devs,
this might all be known issues since this is trunk, but I’ve been testing the tracker (EC/TC) part of trunk the last two days and though I’d report the issues I’ve come over:
- TC: «auto-generate event» and «open data entry after enrollment» does not seem to work, at least not in the instance I’ve tested with (worked in 2.23)

Thanks for the tip. We found it on the latest trunk in testing of 2.24, but then it might be a problem back to 2.23 as well.

- TC: the new «show error and prevent completion» program rule action is not triggered if there are also required/compulsory fields that are missing when clicking complete. I think it would make sense to show all errors that prevent the complete action when clicking complete?

That is a sound suggestion. We could show a list of the required fields together with other errors and or warnings upon completion. Will make a 2.24 feature request and see if I get to it :slight_smile:

- TC: I get an exception related to a program rule when enrolling new TEIs (see screenshots). It tries to access the trackedentityattribute.id of the «effect», which is null because the programruleaction is linked only to a data element. (This is an «ASSIGN» type action).

I see. Will add a check that prevents this from failing. You can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

- Backend/maintenance: the programruleaction table leaves «orphaned» actions, e.g. action not associated with a rule - I assume these should have been deleted?

Yes, you are right that this might happen. This should be cleaned up - created a bug: https://bugs.launchpad.net/dhis2/+bug/1597137

···

28. jun. 2016 kl. 14.52 skrev Olav Poppe <olav.poppe@me.com>:
- EC: would be nice if report date could be embedded in custom forms - support for this seems to have been going in and out over the last few versions
- TC/EC: Form/font sizes seems to be different for custom forms in the two apps. EC size (12pt) seems more «normal» to me (vs 14pt in TC)
- + a few program rule issues already sent to Markus…

Regards
Olav

<Skjermbilde 2016-06-28 kl. 09.48.50.png><Skjermbilde 2016-06-28 kl. 09.48.37.png>
_______________________________________________
Mailing list: DHIS 2 developers in Launchpad
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : DHIS 2 developers in Launchpad
More help : ListHelp - Launchpad Help

Hi Olav,

Thanks for reporting these issues. With Markus commenting on those issues related to program rule, I can comment on the others.

The font size issue is fixed.

Event auto generation is also reported during our internal testing phase - so that will be fixed for 2.24.

Adding event date in custom forms was something we had long before. Now seems we no more allow for adding event date during custom form design - I will try to investigate. But can’t promise if this is going to make it before 2.24.

···

On Wed, Jun 29, 2016 at 1:46 AM, Markus Bekken markus.bekken@gmail.com wrote:

Thanks Olav,

see some inline comments.

  1. jun. 2016 kl. 14.52 skrev Olav Poppe olav.poppe@me.com:

Hi devs,

this might all be known issues since this is trunk, but I’ve been testing the tracker (EC/TC) part of trunk the last two days and though I’d report the issues I’ve come over:

  • TC: «auto-generate event» and «open data entry after enrollment» does not seem to work, at least not in the instance I’ve tested with (worked in 2.23)

Thanks for the tip. We found it on the latest trunk in testing of 2.24, but then it might be a problem back to 2.23 as well.

  • TC: the new «show error and prevent completion» program rule action is not triggered if there are also required/compulsory fields that are missing when clicking complete. I think it would make sense to show all errors that prevent the complete action when clicking complete?

That is a sound suggestion. We could show a list of the required fields together with other errors and or warnings upon completion. Will make a 2.24 feature request and see if I get to it :slight_smile:

  • TC: I get an exception related to a program rule when enrolling new TEIs (see screenshots). It tries to access the trackedentityattribute.id of the «effect», which is null because the programruleaction is linked only to a data element. (This is an «ASSIGN» type action).

I see. Will add a check that prevents this from failing. You can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

  • Backend/maintenance: the programruleaction table leaves «orphaned» actions, e.g. action not associated with a rule - I assume these should have been deleted?

Yes, you are right that this might happen. This should be cleaned up - created a bug: https://bugs.launchpad.net/dhis2/+bug/1597137

  • EC: would be nice if report date could be embedded in custom forms - support for this seems to have been going in and out over the last few versions
  • TC/EC: Form/font sizes seems to be different for custom forms in the two apps. EC size (12pt) seems more «normal» to me (vs 14pt in TC)
    • a few program rule issues already sent to Markus…

Regards

Olav

<Skjermbilde 2016-06-28 kl. 09.48.50.png><Skjermbilde 2016-06-28 kl. 09.48.37.png>


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Abyot A. Gizaw.

Senior Engineer, DHIS2

University of Oslo

http://www.dhis2.org

Great, thanks both.

Event date in custom forms isn’t very import, but would be nice to have.

Markus, you write

How do I control when it is run, apart from through the condition? The condition was “when data element X != '’”, assign parts of data element X code to another data element. E.g. the condition should not be true on registration, since the data element would not have a value at that point.

Olav

···

can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

On Wed, Jun 29, 2016 at 1:46 AM, Markus Bekken markus.bekken@gmail.com wrote:

Thanks Olav,

see some inline comments.

  1. jun. 2016 kl. 14.52 skrev Olav Poppe olav.poppe@me.com:

Hi devs,

this might all be known issues since this is trunk, but I’ve been testing the tracker (EC/TC) part of trunk the last two days and though I’d report the issues I’ve come over:

  • TC: «auto-generate event» and «open data entry after enrollment» does not seem to work, at least not in the instance I’ve tested with (worked in 2.23)

Thanks for the tip. We found it on the latest trunk in testing of 2.24, but then it might be a problem back to 2.23 as well.

  • TC: the new «show error and prevent completion» program rule action is not triggered if there are also required/compulsory fields that are missing when clicking complete. I think it would make sense to show all errors that prevent the complete action when clicking complete?

That is a sound suggestion. We could show a list of the required fields together with other errors and or warnings upon completion. Will make a 2.24 feature request and see if I get to it :slight_smile:

  • TC: I get an exception related to a program rule when enrolling new TEIs (see screenshots). It tries to access the trackedentityattribute.id of the «effect», which is null because the programruleaction is linked only to a data element. (This is an «ASSIGN» type action).

I see. Will add a check that prevents this from failing. You can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

  • Backend/maintenance: the programruleaction table leaves «orphaned» actions, e.g. action not associated with a rule - I assume these should have been deleted?

Yes, you are right that this might happen. This should be cleaned up - created a bug: https://bugs.launchpad.net/dhis2/+bug/1597137

  • EC: would be nice if report date could be embedded in custom forms - support for this seems to have been going in and out over the last few versions
  • TC/EC: Form/font sizes seems to be different for custom forms in the two apps. EC size (12pt) seems more «normal» to me (vs 14pt in TC)
    • a few program rule issues already sent to Markus…

Regards

Olav

<Skjermbilde 2016-06-28 kl. 09.48.50.png><Skjermbilde 2016-06-28 kl. 09.48.37.png>


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Abyot A. Gizaw.

Senior Engineer, DHIS2

University of Oslo

http://www.dhis2.org

Good stuff - See comment inline.

Great, thanks both.

Event date in custom forms isn’t very import, but would be nice to have.

Markus, you write

How do I control when it is run, apart from through the condition? The condition was “when data element X != '’”, assign parts of data element X code to another data element. E.g. the condition should not be true on registration, since the data element would not have a value at that point.

Interesting, was going to suggest this very thing - to expand the expression so it would not be true on registration. Seems there is room for a little bit of investigation here :slight_smile: Can I have you DB off the list?

The other workaround option is not available in the program rules UI, but you know how to use the API and database directly so here goes :slight_smile: : You can assign a program stage to the programRule.programStage - this will cause the rule to only be executed in the connected program stage(not in registration or other stages).

···

can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

On Wed, Jun 29, 2016 at 1:46 AM, Markus Bekken markus.bekken@gmail.com wrote:

Thanks Olav,

see some inline comments.

  1. jun. 2016 kl. 14.52 skrev Olav Poppe olav.poppe@me.com:

Hi devs,

this might all be known issues since this is trunk, but I’ve been testing the tracker (EC/TC) part of trunk the last two days and though I’d report the issues I’ve come over:

  • TC: «auto-generate event» and «open data entry after enrollment» does not seem to work, at least not in the instance I’ve tested with (worked in 2.23)

Thanks for the tip. We found it on the latest trunk in testing of 2.24, but then it might be a problem back to 2.23 as well.

  • TC: the new «show error and prevent completion» program rule action is not triggered if there are also required/compulsory fields that are missing when clicking complete. I think it would make sense to show all errors that prevent the complete action when clicking complete?

That is a sound suggestion. We could show a list of the required fields together with other errors and or warnings upon completion. Will make a 2.24 feature request and see if I get to it :slight_smile:

  • TC: I get an exception related to a program rule when enrolling new TEIs (see screenshots). It tries to access the trackedentityattribute.id of the «effect», which is null because the programruleaction is linked only to a data element. (This is an «ASSIGN» type action).

I see. Will add a check that prevents this from failing. You can possibly also make a workarond by writing a rule that would not try to do an assignment of a dataelement when in the registration page.

  • Backend/maintenance: the programruleaction table leaves «orphaned» actions, e.g. action not associated with a rule - I assume these should have been deleted?

Yes, you are right that this might happen. This should be cleaned up - created a bug: https://bugs.launchpad.net/dhis2/+bug/1597137

  • EC: would be nice if report date could be embedded in custom forms - support for this seems to have been going in and out over the last few versions
  • TC/EC: Form/font sizes seems to be different for custom forms in the two apps. EC size (12pt) seems more «normal» to me (vs 14pt in TC)
    • a few program rule issues already sent to Markus…

Regards

Olav

<Skjermbilde 2016-06-28 kl. 09.48.50.png><Skjermbilde 2016-06-28 kl. 09.48.37.png>


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Abyot A. Gizaw.

Senior Engineer, DHIS2

University of Oslo

http://www.dhis2.org