Compile, test - then commit !

Hi,

quite a few times lately there’s been problems with code not compiling and tests not running successfully in trunk, including right now. This is just a gentle reminder of the most basic rule for code discipline:

Before committing to trunk, build all modules and run all unit tests.

With all modules I mean the non-web modules / the modules listed in the root pom. This is important since changes might affect other code. This is why we have unit tests - so that we can do regression testing and make sure that what we do does not brake what we have.

Lars

[INFO] Compilation failure

C:\development\src\dhis2\dhis-2\dhis-services\dhis-service-excel-reporting\src\m
ain\java\org\hisp\dhis\reportexcel\excelitem\hibernate\HibernateExcelItemStore.j

ava:[114,67] cannot find symbol
symbol : method getPeriodType()
location: class org.hisp.dhis.reportexcel.excelitem.ExcelItemGroup

C:\development\src\dhis2\dhis-2\dhis-services\dhis-service-excel-reporting\src\m

ain\java\org\hisp\dhis\reportexcel\excelitem\hibernate\HibernateExcelItemStore.j
ava:[116,16] cannot find symbol
symbol : method setPeriodType(org.hisp.dhis.period.PeriodType)
location: class org.hisp.dhis.reportexcel.excelitem.ExcelItemGroup

C:\development\src\dhis2\dhis-2\dhis-services\dhis-service-excel-reporting\src\m
ain\java\org\hisp\dhis\reportexcel\excelitem\hibernate\HibernateExcelItemStore.j
ava:[153,67] cannot find symbol
symbol : method getPeriodType()

location: class org.hisp.dhis.reportexcel.excelitem.ExcelItemGroup

C:\development\src\dhis2\dhis-2\dhis-services\dhis-service-excel-reporting\src\m
ain\java\org\hisp\dhis\reportexcel\excelitem\hibernate\HibernateExcelItemStore.j

ava:[155,16] cannot find symbol
symbol : method setPeriodType(org.hisp.dhis.period.PeriodType)
location: class org.hisp.dhis.reportexcel.excelitem.ExcelItemGroup