[Bug 1638551] [NEW] Category option group set should be optional for approval level

Public bug reported:

When creating a data approval level under Settings -> Approval in 2.25
and trunk, a category option group set must be specified. This should be
optional, as it was in 2.24 and earlier.

** Affects: dhis2
     Importance: Undecided
         Status: New

···

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  New

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

Note: This is not a problem in the UI, but behind the Web API while
importing the new data approval level. The UI allows the category
option group set to be left blank, but when POSTing the new approval
level, the following message is returned saying that
categoryOptionGroupSet is a required property. It should be optional:

{"httpStatus":"Conflict","httpStatusCode":409,"status":"WARNING","message":"One
more more errors occurred, please see full details in import
report.","response":{"responseType":"ObjectReport","klass":"org.hisp.dhis.dataapproval.DataApprovalLevel","errorReports":[{"message":"Missing
required property
`categoryOptionGroupSet`.","mainKlass":"org.hisp.dhis.dataapproval.DataApprovalLevel","errorKlass":"org.hisp.dhis.dataelement.CategoryOptionGroupSet","errorCode":"E4000"}],"uid":"dj12KaUnskG"}}

···

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  New

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

I tried making the categoryOptionGroupSet property not-null=true
explicitly in the hbm but that had no effect. Perhaps it is recognized
as not-null since its part of a "properties unique="true"" element.

** Changed in: dhis2
   Importance: Undecided => Medium

** Changed in: dhis2
     Assignee: (unassigned) => Morten Olav Hansen (mortenoh)

** Changed in: dhis2
    Milestone: None => 2.25

···

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  New

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

The hibernate mapping and the object definition haven't changed since 2.24.
So something else has changed, maybe the import code? Some third-party
library? Hibernate?

···

On Fri, Nov 4, 2016 at 1:45 PM, Lars Helge Øverland <lars@dhis2.org> wrote:

I tried making the categoryOptionGroupSet property not-null=true
explicitly in the hbm but that had no effect. Perhaps it is recognized
as not-null since its part of a "properties unique="true"" element.

** Changed in: dhis2
   Importance: Undecided => Medium

** Changed in: dhis2
     Assignee: (unassigned) => Morten Olav Hansen (mortenoh)

** Changed in: dhis2
    Milestone: None => 2.25

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  New

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

--
Jim Grace
Core developer, DHIS 2
HISP US Inc.
http://www.dhis2.org <https://www.dhis2.org/>

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  New

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

Should be fixed in 2.25 and master. This was happening due to non-
standard property mapping for dataApprovalLevel (which our schema
introspector didn't understand). So it was overriden with annotation
(@Property), it might have been a bit strict. Relaxed it down to not
required now.

** Changed in: dhis2
       Status: New => Incomplete

** Changed in: dhis2
       Status: Incomplete => Fix Committed

···

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

Great, thanks!

···

On Sun, Nov 6, 2016 at 1:52 AM, Morten Olav Hansen < 1638551@bugs.launchpad.net> wrote:

Should be fixed in 2.25 and master. This was happening due to non-
standard property mapping for dataApprovalLevel (which our schema
introspector didn't understand). So it was overriden with annotation
(@Property), it might have been a bit strict. Relaxed it down to not
required now.

** Changed in: dhis2
       Status: New => Incomplete

** Changed in: dhis2
       Status: Incomplete => Fix Committed

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

--
Jim Grace
Core developer, DHIS 2
HISP US Inc.
http://www.dhis2.org <https://www.dhis2.org/>

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

Great. Can we back-port to 2.24 as well?

···

On Sun, Nov 6, 2016 at 6:52 AM, Morten Olav Hansen < 1638551@bugs.launchpad.net> wrote:

Should be fixed in 2.25 and master. This was happening due to non-
standard property mapping for dataApprovalLevel (which our schema
introspector didn't understand). So it was overriden with annotation
(@Property), it might have been a bit strict. Relaxed it down to not
required now.

** Changed in: dhis2
       Status: New => Incomplete

** Changed in: dhis2
       Status: Incomplete => Fix Committed

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

_______________________________________________
Mailing list: https://launchpad.net/~dhis2-devs
Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help : https://help.launchpad.net/ListHelp

--
Lars Helge Øverland
Lead developer, DHIS 2
University of Oslo
Skype: larshelgeoverland
lars@dhis2.org
http://www.dhis2.org <https://www.dhis2.org/>

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

It worked already in 2.24 and earlier. It was just a problem in 2.25 and
trunk.

···

On Sun, Nov 6, 2016 at 5:19 PM, Lars Helge Øverland <lars@dhis2.org> wrote:

Great. Can we back-port to 2.24 as well?

On Sun, Nov 6, 2016 at 6:52 AM, Morten Olav Hansen < > 1638551@bugs.launchpad.net> wrote:

> Should be fixed in 2.25 and master. This was happening due to non-
> standard property mapping for dataApprovalLevel (which our schema
> introspector didn't understand). So it was overriden with annotation
> (@Property), it might have been a bit strict. Relaxed it down to not
> required now.
>
> ** Changed in: dhis2
> Status: New => Incomplete
>
> ** Changed in: dhis2
> Status: Incomplete => Fix Committed
>
> --
> You received this bug notification because you are a member of DHIS 2
> developers, which is subscribed to DHIS.
> https://bugs.launchpad.net/bugs/1638551
>
> Title:
> Category option group set should be optional for approval level
>
> Status in DHIS:
> Fix Committed
>
> Bug description:
> When creating a data approval level under Settings -> Approval in 2.25
> and trunk, a category option group set must be specified. This should
> be optional, as it was in 2.24 and earlier.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dhis2-devs
> Post to : dhis2-devs@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~dhis2-devs
> More help : https://help.launchpad.net/ListHelp
>

--
Lars Helge Øverland
Lead developer, DHIS 2
University of Oslo
Skype: larshelgeoverland
lars@dhis2.org
http://www.dhis2.org <https://www.dhis2.org/>

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

--
Jim Grace
Core developer, DHIS 2
HISP US Inc.
http://www.dhis2.org <https://www.dhis2.org/>

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions

Yes. the annotation was something new in 225.

···

--
You received this bug notification because you are a member of DHIS 2
developers, which is subscribed to DHIS.
https://bugs.launchpad.net/bugs/1638551

Title:
  Category option group set should be optional for approval level

Status in DHIS:
  Fix Committed

Bug description:
  When creating a data approval level under Settings -> Approval in 2.25
  and trunk, a category option group set must be specified. This should
  be optional, as it was in 2.24 and earlier.

To manage notifications about this bug go to:
https://bugs.launchpad.net/dhis2/+bug/1638551/+subscriptions