Translation regression since introduction of new reporting app

Hi @Edward_Robinson,

I’ve worked on the translations bug that @phil reported and my fix is currently under review. It should solve the structural issue we had in the reports-app with translations. If we still encounter any untranslated strings after this fix is deployed, it will just be a) a hardcoded string, or b) a translatable string for which no translation has been made available yet. Both these type of problems are easy to solve.

If everything goes according to plan, this fix will be merged to master later on today.

Some of the reports are broken in the new app for us as well.

It would be great if you could provide some more information about the types of problems you have encountered with these reports. The HTML based reports in the new reports-app are a little tricky because we essentially have to create a standalone web-page in an iframe that is served from a React app. What is happening in the report-html is completely up to the creator of the template file, and we don’t know what type of CSS & JavaScript assets are required for a given templates to function correctly. We started by only including jQuery and dhis2.utils as JavaScript assets in the iframe, but it was recently brought to our attention that some reports do require other assets (previously available via the struts HTML template) to function correctly.

I suspect the reports that were broken in your instance were also suffering from missing assets, but it would be very useful to have this confirmed.

I’ve recently worked on quite a lot of fixes which should help solve problems with HTML based reports, so it could even be that some of the broken reports are working in the latest version already.

Kind regards,
Hendrik

1 Like