Patch for DataApprovalWorkflow migrations from v2.19 to v2.22

Hi Dhis2-devs,

After upgrading DHIS from 2.19 to 2.22, we found an issue in the new data approval workflows, where we noticed that few of the data approval workflow uids are not generated properly (some uids are lesser than 11 characters). Digging little deeper into the code, we found the root cause of the issue is in the migration script for upgrading to dataApprovalWorkflow.

We have patched it on one of our own branches of DHIS until the fix is merged into DHIS2. Please find the patch on Launchpad at:

http://bazaar.launchpad.net/~tw-msf/dhis2/v222_api_patch/revision/21956

The diff has also been attached below.

Thanks,

Hari/Jhansi

Hi Hari/Jhansi,

Thank you for alerting us to this. We had fixed this problem in trunk, but somehow we missed applying the fix to 2.22. This has now been done:

Trunk: http://bazaar.launchpad.net/~dhis2-devs-core/dhis2/trunk/revision/21831

2.22: http://bazaar.launchpad.net/~dhis2-devs-core/dhis2/2.22/revision/22049

I apologize that we missed applying this fix at the time to 2.22, but appreciate you bringing this to our attention.

Cheers,

Jim

···

On Tue, May 17, 2016 at 2:45 AM, jhansi jhansirk@thoughtworks.com wrote:

Hi Dhis2-devs,

After upgrading DHIS from 2.19 to 2.22, we found an issue in the new data approval workflows, where we noticed that few of the data approval workflow uids are not generated properly (some uids are lesser than 11 characters). Digging little deeper into the code, we found the root cause of the issue is in the migration script for upgrading to dataApprovalWorkflow.

We have patched it on one of our own branches of DHIS until the fix is merged into DHIS2. Please find the patch on Launchpad at:

http://bazaar.launchpad.net/~tw-msf/dhis2/v222_api_patch/revision/21956

The diff has also been attached below.

Thanks,

Hari/Jhansi


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Jim Grace
Core developer, DHIS 2

HISP US Inc.

http://www.dhis2.org