Incorrect Content-Type for Data Approvals API (GET /dataApprovals/status)

Hi dhis2-devs,

During testing we discovered that the Content-Type is not being set correctly for the GET /dataApprovals/status API calls. This has ramifications if you have enabled Gzip compression in your web server and it looks for specific content types to enable compression (in our case it looks for application/json).

We have patched it on our own branch of DHIS until the fix is merged into DHIS2. Please find the patch on Launchpad at:

http://bazaar.launchpad.net/~tw-msf/dhis2/dhis2/revision/19288

The diff has also been attached below.

Cheers,

19288_19287.diff (628 Bytes)

···

-doh

Hi David

I have applied your patch to 2.20 (+ fixed other data approval endpoints), I have also made similar changes to the controller in 2.21, 2.22, and trunk (which uses renderService and not JacksonUtils anymore)

···

On Thu, Feb 4, 2016 at 12:53 AM, David Siang Fong Oh doh@thoughtworks.com wrote:

Hi dhis2-devs,

During testing we discovered that the Content-Type is not being set correctly for the GET /dataApprovals/status API calls. This has ramifications if you have enabled Gzip compression in your web server and it looks for specific content types to enable compression (in our case it looks for application/json).

We have patched it on our own branch of DHIS until the fix is merged into DHIS2. Please find the patch on Launchpad at:

http://bazaar.launchpad.net/~tw-msf/dhis2/dhis2/revision/19288

The diff has also been attached below.

Cheers,

-doh


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Morten