Error building web maintenance orgunit module

Anyone else seeing this from trunk?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project dhis-web-maintenance-organisationunit: Compilation failure

[ERROR] /home/bobj/src/dhis/trunk/dhis2/dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitlevel/SaveOrganisationUnitLevelsAction.java:[69,98] error: cannot access HttpServletRequest

Answering my own question … I see jenkins is also choking http://apps.dhis2.org/ci/job/dhis-web-trunk/8269/changes#detail2

I don’t really understand how any of my changes are having any effect on this module but it seems they are.

···

On 1 October 2013 15:46, Bob Jolliffe bobjolliffe@gmail.com wrote:

Anyone else seeing this from trunk?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project dhis-web-maintenance-organisationunit: Compilation failure

[ERROR] /home/bobj/src/dhis/trunk/dhis2/dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitlevel/SaveOrganisationUnitLevelsAction.java:[69,98] error: cannot access HttpServletRequest

It shouldn’t really happen.

Can you please add this dependency to the dashboard, organisation unit and visualizer web modules? (Having a merged branch in my checkout so cannot commit myself)

javax.servlet

servlet-api

···

On Tue, Oct 1, 2013 at 5:25 PM, Bob Jolliffe bobjolliffe@gmail.com wrote:

Answering my own question … I see jenkins is also choking http://apps.dhis2.org/ci/job/dhis-web-trunk/8269/changes#detail2

I don’t really understand how any of my changes are having any effect on this module but it seems they are.


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

On 1 October 2013 15:46, Bob Jolliffe bobjolliffe@gmail.com wrote:

Anyone else seeing this from trunk?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project dhis-web-maintenance-organisationunit: Compilation failure

[ERROR] /home/bobj/src/dhis/trunk/dhis2/dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitlevel/SaveOrganisationUnitLevelsAction.java:[69,98] error: cannot access HttpServletRequest

Should be ok now. The same problem was also there in web import-export module. I guess servlet-api was being picked up as a dependency of camel. Should we put it in web commons instead of dotted around all these poms?

···

On 1 October 2013 16:45, Lars Helge Øverland larshelge@gmail.com wrote:

It shouldn’t really happen.

Can you please add this dependency to the dashboard, organisation unit and visualizer web modules? (Having a merged branch in my checkout so cannot commit myself)

javax.servlet

servlet-api

On Tue, Oct 1, 2013 at 5:25 PM, Bob Jolliffe bobjolliffe@gmail.com wrote:

Answering my own question … I see jenkins is also choking http://apps.dhis2.org/ci/job/dhis-web-trunk/8269/changes#detail2

I don’t really understand how any of my changes are having any effect on this module but it seems they are.


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

On 1 October 2013 15:46, Bob Jolliffe bobjolliffe@gmail.com wrote:

Anyone else seeing this from trunk?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile (default-compile) on project dhis-web-maintenance-organisationunit: Compilation failure

[ERROR] /home/bobj/src/dhis/trunk/dhis2/dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitlevel/SaveOrganisationUnitLevelsAction.java:[69,98] error: cannot access HttpServletRequest

Funny thing is it's already in commons... But is seems Maven is not picking
it up properly. Could be some exclusions going on.

···

On Tue, Oct 1, 2013 at 6:03 PM, Bob Jolliffe <bobjolliffe@gmail.com> wrote:

Should be ok now. The same problem was also there in web import-export
module. I guess servlet-api was being picked up as a dependency of camel.
Should we put it in web commons instead of dotted around all these poms?

Yes well the important short term thing is to get trunk building again. Then we can investigate this further. (My local build is happy again. And I see jenkins has just completed) Hate it when a 1 hour job takes the whole afternoon :frowning:

The integration module is now completely gone. Just need to purge from the docs.

···

On 1 October 2013 17:09, Lars Helge Øverland larshelge@gmail.com wrote:

On Tue, Oct 1, 2013 at 6:03 PM, Bob Jolliffe bobjolliffe@gmail.com wrote:

Should be ok now. The same problem was also there in web import-export module. I guess servlet-api was being picked up as a dependency of camel. Should we put it in web commons instead of dotted around all these poms?

Funny thing is it’s already in commons… But is seems Maven is not picking it up properly. Could be some exclusions going on.

Good.

···

On Tue, Oct 1, 2013 at 6:28 PM, Bob Jolliffe bobjolliffe@gmail.com wrote:

Yes well the important short term thing is to get trunk building again. Then we can investigate this further. (My local build is happy again. And I see jenkins has just completed) Hate it when a 1 hour job takes the whole afternoon :frowning:

The integration module is now completely gone. Just need to purge from the docs.

On 1 October 2013 17:09, Lars Helge Øverland larshelge@gmail.com wrote:

On Tue, Oct 1, 2013 at 6:03 PM, Bob Jolliffe bobjolliffe@gmail.com wrote:

Should be ok now. The same problem was also there in web import-export module. I guess servlet-api was being picked up as a dependency of camel. Should we put it in web commons instead of dotted around all these poms?

Funny thing is it’s already in commons… But is seems Maven is not picking it up properly. Could be some exclusions going on.