Bug: Sharing Settings Reset on Update for Category Combinations Only

Hello Devs,

Verified on the SL Demo Server

Saw some peculiar activity when a user updated a private category combination that had been shared with them “can edit and view”. It cleared out all the sharing settings and left the element as private so only the original creator or superuser could find it.

This sharing reset behavior seems only to affect the category combination, updates to categories will retain their prior sharing settings.

Steps to reproduce:

  1. As Admin: Create user role with the following:
  • Add/Update Private Data Element Category Combo
  • See Dashboard integration module
  • See Data Elements and Indicators Maintenance module
  1. Create a user group

  2. Create a new user with the role from step 1 and the group from step 2

  3. Create a category combination

  4. Make CatCombo private and share read/write with the group from step 2

  5. Log in as user from step 3, and make any edit to the catcombo. The sharing settings will be removed and the element will be private.

Before Step 6:

After Step 6:

image

···

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

Hello Devs and good morning/afternoon wherever you might be,

I just checked out version 2.21 on the apps/demo site and found that the category combination sharing reset bug persists. I’ve paired down the steps to reproduce quite a bit so you can check it out for yourself with just a few taps and clicks:

  1. Edit the sharing settings of an existing cat combo by adding a new group.

  2. Edit the sharing setting in the traditional sense (I usually add a letter to the name just for testing)

  3. Observe that the sharing settings from step one have been removed.

  4. Added Kenya staff
    Inline image 1

  5. (I added “test_” to the beginning of the name)

Inline image 2

  1. Observe that Kenya staff have been removed.

Inline image 3

Let me know if you need any more specifics. The problem is most confusing for private users editing private Cat Combos. If they are not the creator, as soon as they make a chance they lose the ability to edit the cat combo and it disappears.

Cheers!

image

···

On Mon, Oct 19, 2015 at 12:36 PM, Timothy Harding tharding@baosystems.com wrote:

Hello Devs,

Verified on the SL Demo Server

Saw some peculiar activity when a user updated a private category combination that had been shared with them “can edit and view”. It cleared out all the sharing settings and left the element as private so only the original creator or superuser could find it.

This sharing reset behavior seems only to affect the category combination, updates to categories will retain their prior sharing settings.

Steps to reproduce:

  1. As Admin: Create user role with the following:
  • Add/Update Private Data Element Category Combo
  • See Dashboard integration module
  • See Data Elements and Indicators Maintenance module
  1. Create a user group
  1. Create a new user with the role from step 1 and the group from step 2
  1. Create a category combination
  1. Make CatCombo private and share read/write with the group from step 2
  1. Log in as user from step 3, and make any edit to the catcombo. The sharing settings will be removed and the element will be private.

Before Step 6:

After Step 6:

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

Hi Timothy,

I will have a look and get back to you

image

image

image

image

···

On Thu, Oct 22, 2015 at 1:13 PM, Timothy Harding tharding@baosystems.com wrote:

Hello Devs and good morning/afternoon wherever you might be,

I just checked out version 2.21 on the apps/demo site and found that the category combination sharing reset bug persists. I’ve paired down the steps to reproduce quite a bit so you can check it out for yourself with just a few taps and clicks:

  1. Edit the sharing settings of an existing cat combo by adding a new group.
  1. Edit the sharing setting in the traditional sense (I usually add a letter to the name just for testing)
  1. Observe that the sharing settings from step one have been removed.
  1. Added Kenya staff
  1. (I added “test_” to the beginning of the name)
  1. Observe that Kenya staff have been removed.

Let me know if you need any more specifics. The problem is most confusing for private users editing private Cat Combos. If they are not the creator, as soon as they make a chance they lose the ability to edit the cat combo and it disappears.

Cheers!


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Morten

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

On Mon, Oct 19, 2015 at 12:36 PM, Timothy Harding tharding@baosystems.com wrote:

Hello Devs,

Verified on the SL Demo Server

Saw some peculiar activity when a user updated a private category combination that had been shared with them “can edit and view”. It cleared out all the sharing settings and left the element as private so only the original creator or superuser could find it.

This sharing reset behavior seems only to affect the category combination, updates to categories will retain their prior sharing settings.

Steps to reproduce:

  1. As Admin: Create user role with the following:
  • Add/Update Private Data Element Category Combo
  • See Dashboard integration module
  • See Data Elements and Indicators Maintenance module
  1. Create a user group
  1. Create a new user with the role from step 1 and the group from step 2
  1. Create a category combination
  1. Make CatCombo private and share read/write with the group from step 2
  1. Log in as user from step 3, and make any edit to the catcombo. The sharing settings will be removed and the element will be private.

Before Step 6:

After Step 6:

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

Hi Timothy

This have now been fixed in 2.20, 2.21 and trunk

image

image

image

image

···

On Thu, Oct 22, 2015 at 1:16 PM, Morten Olav Hansen mortenoh@gmail.com wrote:

Hi Timothy,

I will have a look and get back to you


Morten


Morten

On Thu, Oct 22, 2015 at 1:13 PM, Timothy Harding tharding@baosystems.com wrote:

Hello Devs and good morning/afternoon wherever you might be,

I just checked out version 2.21 on the apps/demo site and found that the category combination sharing reset bug persists. I’ve paired down the steps to reproduce quite a bit so you can check it out for yourself with just a few taps and clicks:

  1. Edit the sharing settings of an existing cat combo by adding a new group.
  1. Edit the sharing setting in the traditional sense (I usually add a letter to the name just for testing)
  1. Observe that the sharing settings from step one have been removed.
  1. Added Kenya staff
  1. (I added “test_” to the beginning of the name)
  1. Observe that Kenya staff have been removed.

Let me know if you need any more specifics. The problem is most confusing for private users editing private Cat Combos. If they are not the creator, as soon as they make a chance they lose the ability to edit the cat combo and it disappears.

Cheers!


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007

On Mon, Oct 19, 2015 at 12:36 PM, Timothy Harding tharding@baosystems.com wrote:

Hello Devs,

Verified on the SL Demo Server

Saw some peculiar activity when a user updated a private category combination that had been shared with them “can edit and view”. It cleared out all the sharing settings and left the element as private so only the original creator or superuser could find it.

This sharing reset behavior seems only to affect the category combination, updates to categories will retain their prior sharing settings.

Steps to reproduce:

  1. As Admin: Create user role with the following:
  • Add/Update Private Data Element Category Combo
  • See Dashboard integration module
  • See Data Elements and Indicators Maintenance module
  1. Create a user group
  1. Create a new user with the role from step 1 and the group from step 2
  1. Create a category combination
  1. Make CatCombo private and share read/write with the group from step 2
  1. Log in as user from step 3, and make any edit to the catcombo. The sharing settings will be removed and the element will be private.

Before Step 6:

After Step 6:

Timothy Harding
Sr. Systems Analyst, BAO Systems

+1 202-536-1541 | tharding@baosystems.com | http://www.baosystems.com | Skype: hardingt@gmail.com | 2900 K Street, Suite 404, Washington D.C. 20007