[Branch ~dhis2-devs-core/dhis2/trunk] Rev 835: Quickly fixed ...

revision-diff.txt (818 Bytes)

GenerateAdvancedReportExcelOrganisationGroupListingAction.java

This is a long name Hieu :slight_smile:

···

On Thu, Oct 8, 2009 at 8:50 AM, noreply@launchpad.net wrote:


revno: 835
committer: hieu hieu.hispvietnam@gmail.com
branch nick: trunk

timestamp: Thu 2009-10-08 13:46:18 +0700
message:
Quickly fixed …
modified:
dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java


lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java’

— dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java 2009-10-08 03:43:00 +0000
+++ dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java 2009-10-08 06:46:18 +0000

@@ -86,6 +86,8 @@
public String execute()
throws Exception
{

  •    statementManager.initialise();
    
  •   Period period = selectionManager.getSelectedPeriod();
    
    this.installExcelFormat();

Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs
More help : https://help.launchpad.net/ListHelp

Yeahhh, we have a slogan for any java file “MORE LONGER MORE CLEARLY”. Btw, is there a bad thing here ? Give me any suggestion if you got from issue … a lots of thanks !

···

On Thu, Oct 8, 2009 at 2:03 PM, Abyot Gizaw abyota@gmail.com wrote:

GenerateAdvancedReportExcelOrganisationGroupListingAction.java

This is a long name Hieu :slight_smile:

On Thu, Oct 8, 2009 at 8:50 AM, noreply@launchpad.net wrote:


revno: 835
committer: hieu hieu.hispvietnam@gmail.com
branch nick: trunk

timestamp: Thu 2009-10-08 13:46:18 +0700
message:
Quickly fixed …
modified:
dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java


lp:dhis2
https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java’

— dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java 2009-10-08 03:43:00 +0000
+++ dhis-2/dhis-web/dhis-web-excel-reporting/src/main/java/org/hisp/dhis/reportexcel/export/advance/action/GenerateAdvancedReportExcelOrganisationGroupListingAction.java 2009-10-08 06:46:18 +0000

@@ -86,6 +86,8 @@
public String execute()
throws Exception
{

  •    statementManager.initialise();
    
  •   Period period = selectionManager.getSelectedPeriod();
    
    this.installExcelFormat();

Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Hieu.HISPVietnam
Good Health !

GenerateAdvancedReportExcelOrganisationGroupListingAction.java

Generate for generating
Advanced for advanced function of Generating report.
Report Excel is for seperate Report Excel module
OrganisationGroupListing is a report type (Normal, Category, PeriodListing type)

ReportExcelOrganisationGroupListing was required by Lars.

···

Thuy
HISP Vietnam
+84902079126

Hi Thuy

I see the class
GenerateAdvancedReportExcelOrganisationGroupListingAction.java

exists in the package:

package org.hisp.dhis.reportexcel.export.advance.action;

If you think of the package as providing some sort of namespace scoping, then there is no need to repeat the words from the package in the name of the class.

In which case I think
GenerateOrganisationGroupListingAction

is adequate. Its “fully qualified” name would be:
org.hisp.dhis.reportexcel.export.advance.action.GenerateOrganisationGroupListingAction

Regards
Bob

···

2009/10/8 Thuy Nguyen thuy.hispvietnam@gmail.com

GenerateAdvancedReportExcelOrganisationGroupListingAction.java

Generate for generating
Advanced for advanced function of Generating report.
Report Excel is for seperate Report Excel module
OrganisationGroupListing is a report type (Normal, Category, PeriodListing type)

ReportExcelOrganisationGroupListing was required by Lars.

Thuy
HISP Vietnam
+84902079126


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp