[Branch ~dhis2-devs-core/dhis2/trunk] Rev 1184: fixed : disabled all input text when data set completed

revision-diff.txt (2.64 KB)

All input fields are now disabled when the complete button is clicked.

Is this the behaviour we want? Should one be able to say that the form is “reasonably” complete and then be able to enter more data later or is the form “locked” when the complete button is clicked?

···

On Wed, Dec 9, 2009 at 4:46 AM, noreply@launchpad.net wrote:


revno: 1184

committer: Tran Thanh Tri <Tran Thanh Tri@compaq>

branch nick: trunk

timestamp: Wed 2009-12-09 10:43:38 +0700

message:

fixed : disabled all input text when data set completed

modified:

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js

lp:dhis2

https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-03-03 16:46:36 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-12-09 03:43:38 +0000

@@ -26,4 +26,11 @@

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-11-07 14:09:00 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-12-09 03:43:38 +0000

@@ -6,7 +6,7 @@

#parse( “/dhis-web-dataentry/select.vm” )

+

#if ( $customDataEntryFormExists && !$useDefaultForm )

            #foreach( $optionCombo in $orderdCategoryOptionCombos )

@@ -171,7 +171,7 @@

#end

#end

+

#parse( “/dhis-web-dataentry/completeRegistration.vm” )

=== modified file 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js' --- dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-03-12 11:40:58 +0000 +++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-12-09 03:43:38 +0000 @@ -303,6 +303,7 @@ document.getElementById( "undoButton" ).disabled = false; document.getElementById( "dateField" ).disabled = true; document.getElementById( "dateDiv" ).style.display = "none"; + disableInputField(); } function undoCompleteDataSet() @@ -325,4 +326,25 @@ document.getElementById( "undoButton" ).disabled = true; document.getElementById( "dateField" ).disabled = false; document.getElementById( "dateDiv" ).style.display = "inline"; + enableInputField(); +} + +function disableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = true; + } +} + +function enableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = false; + } } _______________________________________________ Mailing list: [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) Post to : dhis2-devs@lists.launchpad.net Unsubscribe : [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) More help : [https://help.launchpad.net/ListHelp](https://help.launchpad.net/ListHelp)

I don’t like locking the datasets just because they are completely filled. They might have outliers, typos, whatever errors that need to be corrected later, and there might also as Lars indicates be more data to be filled in a later stage, in addition to the “mandatory” ones that define a relatively complete set.

Complete to be does not indicate anything on the data quality, just its completeness and therefore should not be considered final and locked.

At least this should be made a non-default system setting that Vietnam and others that likes this can tick. It does not sound like a default behaviour to me.

Ola

···

2009/12/9 Lars Helge Øverland larshelge@gmail.com

All input fields are now disabled when the complete button is clicked.

Is this the behaviour we want? Should one be able to say that the form is “reasonably” complete and then be able to enter more data later or is the form “locked” when the complete button is clicked?


On Wed, Dec 9, 2009 at 4:46 AM, noreply@launchpad.net wrote:


revno: 1184

committer: Tran Thanh Tri <Tran Thanh Tri@compaq>

branch nick: trunk

timestamp: Wed 2009-12-09 10:43:38 +0700

message:

fixed : disabled all input text when data set completed

modified:

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js

lp:dhis2

https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-03-03 16:46:36 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-12-09 03:43:38 +0000

@@ -26,4 +26,11 @@

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-11-07 14:09:00 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-12-09 03:43:38 +0000

@@ -6,7 +6,7 @@

#parse( “/dhis-web-dataentry/select.vm” )

+

#if ( $customDataEntryFormExists && !$useDefaultForm )

            #foreach( $optionCombo in $orderdCategoryOptionCombos )

@@ -171,7 +171,7 @@

#end

#end

+

#parse( “/dhis-web-dataentry/completeRegistration.vm” )

=== modified file 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js' --- dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-03-12 11:40:58 +0000 +++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-12-09 03:43:38 +0000 @@ -303,6 +303,7 @@ document.getElementById( "undoButton" ).disabled = false; document.getElementById( "dateField" ).disabled = true; document.getElementById( "dateDiv" ).style.display = "none"; + disableInputField(); } function undoCompleteDataSet() @@ -325,4 +326,25 @@ document.getElementById( "undoButton" ).disabled = true; document.getElementById( "dateField" ).disabled = false; document.getElementById( "dateDiv" ).style.display = "inline"; + enableInputField(); +} + +function disableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = true; + } +} + +function enableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = false; + } } _______________________________________________ Mailing list: [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) Post to : dhis2-devs@lists.launchpad.net Unsubscribe : [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) More help : [https://help.launchpad.net/ListHelp](https://help.launchpad.net/ListHelp)

Hi.

This is the behavior we want. I 'm sure. If following you way, what did we do with Undo button ? If all input text not disable when dataset completed: User can change data value after they completed our data and Completed data set will not meaning and invalid.

I want user can’t not change data after registry completed dataset. If they want to change, they must click on Undo .

Trust me. It was using for 2 systems in HCMC and really useful with this way.

···

================================
Tran Thanh Tri
HISP Viet Nam
Cell phone: +84903670967
Website: http://tringuyenvn.com

================================

2009/12/9 Lars Helge Øverland larshelge@gmail.com

All input fields are now disabled when the complete button is clicked.

Is this the behaviour we want? Should one be able to say that the form is “reasonably” complete and then be able to enter more data later or is the form “locked” when the complete button is clicked?

On Wed, Dec 9, 2009 at 4:46 AM, noreply@launchpad.net wrote:


revno: 1184

committer: Tran Thanh Tri <Tran Thanh Tri@compaq>

branch nick: trunk

timestamp: Wed 2009-12-09 10:43:38 +0700

message:

fixed : disabled all input text when data set completed

modified:

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js

lp:dhis2

https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-03-03 16:46:36 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-12-09 03:43:38 +0000

@@ -26,4 +26,11 @@

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-11-07 14:09:00 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-12-09 03:43:38 +0000

@@ -6,7 +6,7 @@

#parse( “/dhis-web-dataentry/select.vm” )

+

#if ( $customDataEntryFormExists && !$useDefaultForm )

            #foreach( $optionCombo in $orderdCategoryOptionCombos )

@@ -171,7 +171,7 @@

#end

#end

+

#parse( “/dhis-web-dataentry/completeRegistration.vm” )

=== modified file 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js' --- dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-03-12 11:40:58 +0000 +++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-12-09 03:43:38 +0000 @@ -303,6 +303,7 @@ document.getElementById( "undoButton" ).disabled = false; document.getElementById( "dateField" ).disabled = true; document.getElementById( "dateDiv" ).style.display = "none"; + disableInputField(); } function undoCompleteDataSet() @@ -325,4 +326,25 @@ document.getElementById( "undoButton" ).disabled = true; document.getElementById( "dateField" ).disabled = false; document.getElementById( "dateDiv" ).style.display = "inline"; + enableInputField(); +} + +function disableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = true; + } +} + +function enableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = false; + } } _______________________________________________ Mailing list: [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) Post to : dhis2-devs@lists.launchpad.net Unsubscribe : [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) More help : [https://help.launchpad.net/ListHelp](https://help.launchpad.net/ListHelp)

Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

Tri,

If that is what you need in Vietnam, and I am sure you know that best, then we need to support it.

But that doesn’t mean the rest of the world want it the same way, that was my point. The way data is audited and who sets a dataset to completed or locked varies from country to country. Such differences in use are best modelled through optional system settings I think, that gives each country or state the flexibility to choose the behaviour of the system that they prefer.

Ola Hodne Titlestad |Technical Officer|
Health Metrics Network (HMN) | World Health Organization
Avenue Appia 20 |1211 Geneva 27, Switzerland | Email: titlestado@who.int|Tel: +41 788216897

Website: www.healthmetricsnetwork.org

Better Information. Better Decisions. Better Health.

···

2009/12/9 Trí Trần Thanh tranthanhtri84@gmail.com

Hi.
This is the behavior we want. I 'm sure. If following you way, what did we do with Undo button ? If all input text not disable when dataset completed: User can change data value after they completed our data and Completed data set will not meaning and invalid.

I want user can’t not change data after registry completed dataset. If they want to change, they must click on Undo .

Trust me. It was using for 2 systems in HCMC and really useful with this way.

================================
Tran Thanh Tri
HISP Viet Nam
Cell phone: +84903670967
Website: http://tringuyenvn.com

================================

2009/12/9 Lars Helge Øverland larshelge@gmail.com

All input fields are now disabled when the complete button is clicked.

Is this the behaviour we want? Should one be able to say that the form is “reasonably” complete and then be able to enter more data later or is the form “locked” when the complete button is clicked?

On Wed, Dec 9, 2009 at 4:46 AM, noreply@launchpad.net wrote:


revno: 1184

committer: Tran Thanh Tri <Tran Thanh Tri@compaq>

branch nick: trunk

timestamp: Wed 2009-12-09 10:43:38 +0700

message:

fixed : disabled all input text when data set completed

modified:

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm

dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js

lp:dhis2

https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk

Your team DHIS 2 developers is subscribed to branch lp:dhis2.

To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription.

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-03-03 16:46:36 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/completeRegistration.vm 2009-12-09 03:43:38 +0000

@@ -26,4 +26,11 @@

=== modified file ‘dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm’

— dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-11-07 14:09:00 +0000

+++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/form.vm 2009-12-09 03:43:38 +0000

@@ -6,7 +6,7 @@

#parse( “/dhis-web-dataentry/select.vm” )

+

#if ( $customDataEntryFormExists && !$useDefaultForm )

            #foreach( $optionCombo in $orderdCategoryOptionCombos )

@@ -171,7 +171,7 @@

#end

#end

+

#parse( “/dhis-web-dataentry/completeRegistration.vm” )

=== modified file 'dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js' --- dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-03-12 11:40:58 +0000 +++ dhis-2/dhis-web/dhis-web-dataentry/src/main/webapp/dhis-web-dataentry/javascript/form.js 2009-12-09 03:43:38 +0000 @@ -303,6 +303,7 @@ document.getElementById( "undoButton" ).disabled = false; document.getElementById( "dateField" ).disabled = true; document.getElementById( "dateDiv" ).style.display = "none"; + disableInputField(); } function undoCompleteDataSet() @@ -325,4 +326,25 @@ document.getElementById( "undoButton" ).disabled = true; document.getElementById( "dateField" ).disabled = false; document.getElementById( "dateDiv" ).style.display = "inline"; + enableInputField(); +} + +function disableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = true; + } +} + +function enableInputField() +{ + var inputList = byId("dataEntryForm").getElementsByTagName("input"); + + for(var i=0;i<inputList.length;i++){ + var input = inputList.item(i); + input.disabled = false; + } } _______________________________________________ Mailing list: [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) Post to : dhis2-devs@lists.launchpad.net Unsubscribe : [https://launchpad.net/~dhis2-devs](https://launchpad.net/%7Edhis2-devs) More help : [https://help.launchpad.net/ListHelp](https://help.launchpad.net/ListHelp)

Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp

I agree with Ola at this. We do have a data locking functionality (which is a little slow at the time though) which could take care of this. I think we should not mix data locking and completeness. Sorry Tri but I will revert this. Could you instead have a look at the data locking functionality and maybe improve that?

Lars

···

On Wed, Dec 9, 2009 at 9:20 AM, Ola Hodne Titlestad olatitle@gmail.com wrote:

Tri,

If that is what you need in Vietnam, and I am sure you know that best, then we need to support it.

But that doesn’t mean the rest of the world want it the same way, that was my point. The way data is audited and who sets a dataset to completed or locked varies from country to country. Such differences in use are best modelled through optional system settings I think, that gives each country or state the flexibility to choose the behaviour of the system that they prefer.

Ola Hodne Titlestad |Technical Officer|
Health Metrics Network (HMN) | World Health Organization
Avenue Appia 20 |1211 Geneva 27, Switzerland | Email: titlestado@who.int|Tel: +41 788216897

Website: www.healthmetricsnetwork.org

Better Information. Better Decisions. Better Health.

Hi .

I think dataset lock is use for the use like manager of system and completed dataset is use for normal user. The normal user will use dataset completed for confirm “our data was completed to the manage user” and the manage user can use this data and believe this data value is valid. If after 2,3 or 4 month,etc the user can change data, data will wrong. That why we need data set locking.

This is the way we use for Vietnam. it just is my idea. If you don’t then leave it.

···

================================

Tran Thanh Tri
HISP Viet Nam
Cell phone: +84903670967
Website: http://tringuyenvn.com

2009/12/9 Lars Helge Øverland larshelge@gmail.com

On Wed, Dec 9, 2009 at 9:20 AM, Ola Hodne Titlestad olatitle@gmail.com wrote:

Tri,

If that is what you need in Vietnam, and I am sure you know that best, then we need to support it.

But that doesn’t mean the rest of the world want it the same way, that was my point. The way data is audited and who sets a dataset to completed or locked varies from country to country. Such differences in use are best modelled through optional system settings I think, that gives each country or state the flexibility to choose the behaviour of the system that they prefer.

Ola Hodne Titlestad |Technical Officer|
Health Metrics Network (HMN) | World Health Organization
Avenue Appia 20 |1211 Geneva 27, Switzerland | Email: titlestado@who.int|Tel: +41 788216897

Website: www.healthmetricsnetwork.org

Better Information. Better Decisions. Better Health.

I agree with Ola at this. We do have a data locking functionality (which is a little slow at the time though) which could take care of this. I think we should not mix data locking and completeness. Sorry Tri but I will revert this. Could you instead have a look at the data locking functionality and maybe improve that?

Lars

Why do we need two ways of locking then? No need for the manager to lock an already locked dataset, or?

Sometimes the user wants to make changes to old data, e.g. if they discover errors during data analysis.

We need input from other countries here.
Johan, what is the workflow in Sierra Leone on this?

Ola

···

2009/12/9 Trí Trần Thanh tranthanhtri84@gmail.com

Hi .

I think dataset lock is use for the use like manager of system and completed dataset is use for normal user. The normal user will use dataset completed for confirm “our data was completed to the manage user” and the manage user can use this data and believe this data value is valid. If after 2,3 or 4 month,etc the user can change data, data will wrong. That why we need data set locking.

This is the way we use for Vietnam. it just is my idea. If you don’t then leave it.


================================

Tran Thanh Tri
HISP Viet Nam
Cell phone: +84903670967
Website: http://tringuyenvn.com

2009/12/9 Lars Helge Øverland larshelge@gmail.com

On Wed, Dec 9, 2009 at 9:20 AM, Ola Hodne Titlestad olatitle@gmail.com wrote:

Tri,

If that is what you need in Vietnam, and I am sure you know that best, then we need to support it.

But that doesn’t mean the rest of the world want it the same way, that was my point. The way data is audited and who sets a dataset to completed or locked varies from country to country. Such differences in use are best modelled through optional system settings I think, that gives each country or state the flexibility to choose the behaviour of the system that they prefer.

Ola Hodne Titlestad |Technical Officer|
Health Metrics Network (HMN) | World Health Organization
Avenue Appia 20 |1211 Geneva 27, Switzerland | Email: titlestado@who.int|Tel: +41 788216897

Website: www.healthmetricsnetwork.org

Better Information. Better Decisions. Better Health.

I agree with Ola at this. We do have a data locking functionality (which is a little slow at the time though) which could take care of this. I think we should not mix data locking and completeness. Sorry Tri but I will revert this. Could you instead have a look at the data locking functionality and maybe improve that?

Lars

Hi .

I think dataset lock is use for the use like manager of system and completed dataset is use for normal user. The normal user will use dataset completed for confirm “our data was completed to the manage user” and the manage user can use this data and believe this data value is valid. If after 2,3 or 4 month,etc the user can change data, data will wrong. That why we need data set locking.

This is the way we use for Vietnam. it just is my idea. If you don’t then leave it.

Why do we need two ways of locking then? No need for the manager to lock an already locked dataset, or?

Sometimes the user wants to make changes to old data, e.g. if they discover errors during data analysis.

We need input from other countries here.
Johan, what is the workflow in Sierra Leone on this?

It would also be good to hear from India, since that is where the locking functionality initilally surfaced. John?

Knut

···

2009/12/9 Ola Hodne Titlestad olatitle@gmail.com

2009/12/9 Trí Trần Thanh tranthanhtri84@gmail.com

Ola


================================

Tran Thanh Tri
HISP Viet Nam
Cell phone: +84903670967
Website: http://tringuyenvn.com

2009/12/9 Lars Helge Øverland larshelge@gmail.com

On Wed, Dec 9, 2009 at 9:20 AM, Ola Hodne Titlestad olatitle@gmail.com wrote:

Tri,

If that is what you need in Vietnam, and I am sure you know that best, then we need to support it.

But that doesn’t mean the rest of the world want it the same way, that was my point. The way data is audited and who sets a dataset to completed or locked varies from country to country. Such differences in use are best modelled through optional system settings I think, that gives each country or state the flexibility to choose the behaviour of the system that they prefer.

Ola Hodne Titlestad |Technical Officer|
Health Metrics Network (HMN) | World Health Organization
Avenue Appia 20 |1211 Geneva 27, Switzerland | Email: titlestado@who.int|Tel: +41 788216897

Website: www.healthmetricsnetwork.org

Better Information. Better Decisions. Better Health.

I agree with Ola at this. We do have a data locking functionality (which is a little slow at the time though) which could take care of this. I think we should not mix data locking and completeness. Sorry Tri but I will revert this. Could you instead have a look at the data locking functionality and maybe improve that?

Lars


Mailing list: https://launchpad.net/~dhis2-devs

Post to : dhis2-devs@lists.launchpad.net

Unsubscribe : https://launchpad.net/~dhis2-devs

More help : https://help.launchpad.net/ListHelp


Cheers,
Knut Staring